Review requested changes on PR #84 (fix: prevent stack overflow in trend_analysis). Required changes: - Major: spike/outlier split points are silently dropped (IEEE-754 simulation: spike series yields [0,24] + [26,49], index 25 missing), contradicting the PR's validation claim. - Major: recursion depth is still O(n) worst-case (n=10000 convex series -> depth ~4052), so large inputs can still overflow the stack. - Minor: 2-element input with threshold=0.0 returns zero segments. - Minor: no new regression tests; existing test only checks len >= 2.
Activity