Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hpmaxi
marked this pull request as ready for review
October 17, 2026 05:16
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flooring the epoch total and then each claim left a remainder that was never reconciled. It is now. Each epoch records what pricing promised and what has been paid; when its last request settles, the remainder leaves
pending_mint_sharesandcommitted, stays in the reserve as fund money, andEpochReconciledsays how much. Every subtraction from a running total is checked.Changes
get_epoch_settlement, eventEpochReconciled.AccountingMismatch, 6070).Deviations
owed"the same treatment on the last claim". That is not safe: a later round needs those units. The remainder stays (at most one unit per holder), and a test shows why.Acceptance criteria
EpochReconciledTest plan
Automated tests
SOROBAN_SDK_BUILD_SYSTEM_SUPPORTS_SPEC_SHAKING_V2=1 nix develop -c cargo test --locked -p async-vault settlement wind_downManual verification
None.
Breaking changes
None for callers; a new view and a new event. This version must be deployed fresh, or reached by upgrade only when no request is open: the settlement record counts requests from the moment it exists, so upgrading a vault in place while a request is open would under-count its open epochs, reverting claims from epochs priced before the upgrade and risking an early reconcile of a mixed epoch.
Checklist
Screenshots
None.