Skip to content

fix(vault): reopen cancellation while paused - #253

Open
hpmaxi wants to merge 3 commits into
feat/settlement-dustfrom
feat/cancel-window
Open

hpmaxi wants to merge 3 commits into
feat/settlement-dustfrom
feat/cancel-window

Conversation

@hpmaxi

@hpmaxi hpmaxi commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Reopening cancellation when the report goes stale or the NAV is paused is the deliberate way out of a stalled feed, and now it is written down. A readable price closes cancellation even during the notice; if the vault can no longer price the epoch (an expired report, a raised NAV pause, or a paused vault) it reopens; the epoch is priced at the latest valid report at fulfil time. The paused-vault case is a fix: a paused vault cannot price, so it no longer holds investors in. The health warning follows separately.

Changes

  • A paused vault's sealed epochs are cancellable until the pause lifts.
  • A test pins the window reopening after the price that closed it expires.
  • Kit-spec Invariants 5 and 6 and the design doc state the rules. The dApp's message is plan 04's checklist item a4.

Acceptance criteria

  • Cancelling a sealed epoch works while paused, and stops again after unpause while the price is readable
  • A test shows cancellation reopening after the closing price expires
  • The kit spec and design doc state the three rules

Test plan

Automated tests

  1. SOROBAN_SDK_BUILD_SYSTEM_SUPPORTS_SPEC_SHAKING_V2=1 nix develop -c cargo test --locked -p async-vault cancel::

Manual verification

None.

Breaking changes

None.

Checklist

  • Self-reviewed my own diff
  • Tests added or updated
  • Docs updated (if applicable)
  • No unrelated changes bundled in

Screenshots

None.

@vercel

vercel Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
strata-vault-kit-app Ready Ready Preview Oct 19, 2026 5:32pm UTC

Request Review

@hpmaxi
hpmaxi marked this pull request as ready for review October 17, 2026 05:45

This branch was successfully deployed

1 active deployment
Preview — ddbc63ca Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant