Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hpmaxi
marked this pull request as ready for review
October 17, 2026 07:46
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aha A, the open part: a holder delisted after their deposit was priced. Our reply said her claim moves the priced shares into the exit queue, a wind-down credits them to her entitlement, and a frozen holder is held, not converted. This PR builds that: the vault mints the shares into its escrow and adds them to her redemption in the open epoch, paid in cash at that epoch's price like every other exit. In a wind-down they join her entitlement, and the supply snapshot counts them. This PR answers the rest of aha's comment A.
Changes
claim_depositby a caller off the allowlist converts the claim into a redemption in the open epoch (DepositConvertedToExit), or in an active wind-down credits the shares to her entitlement.cancel_redeemburns the escrow into the entitlement (RedemptionSurrendered); no token pause or allowlist place can hold it.Frozen, 6071) onclaim_depositandcancel_redeem, and refused onrequest_deposit.Deviations
request_depositand held atclaim_depositeven while listed; before, both went through.cancel_redeemoutside a wind-down fails withNotAllowlisted, not the token'sIdentityVerificationFailed.Acceptance criteria
claim_depositmints the shares into the vault's escrow and queues them in the open epoch (DepositConvertedToExit)RedemptionSurrendered)Frozen, 6071), delisted or notTest plan
Automated tests
SOROBAN_SDK_BUILD_SYSTEM_SUPPORTS_SPEC_SHAKING_V2=1 nix develop -c cargo test --locked -p async-vault: 307 passed, among themdelisted,lock_policy(one test per cell of the lock table),complianceandwind_down.conversions_settle_the_epoch_in_any_orderruns 16 random epochs.stellar/quickstartnetwork: guards 38/38 and happy path 24/24.Manual verification
None.
Breaking changes
claim_depositreturns 0 and publishesDepositConvertedToExitinstead of failing for a delisted caller.cancel_redeempublishesRedemptionSurrenderedand returns no shares; a zero-assetclaim_redeemburns the shares and publishesRedeemClaimedwith 0 assets.Frozen(6071). A delisted holder'scancel_redeemfails with 6068 instead of the token's 304.Checklist
Screenshots
None.