Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hpmaxi
marked this pull request as ready for review
October 17, 2026 09:04
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #171
The vault ignored freezes: a frozen holder could still exit, claim shares and collect a wind-down slice. Freezing now holds everything not yet out, recorded and protected, until an unfreeze; a frozen holder is held, not converted. A legal-order transfer moves only wallet shares; releasing value the vault holds under an order is a follow-up issue.
Changes
Frozen(6071) on request and claim of exits, cancel of deposits, and wind-down claimscommitted; a held wind-down slice stays inwind_down_owedlock_policy's table grows to cover every exit; no entrypoint checks the token's freeze itselfDeviations
transferrow stay intact.ShareToken::is_frozen"), sinceclaim_redeemnow does.claim_deposit's refusal of a frozen mint already shipped in an earlier PR, so it is not relisted here.Acceptance criteria
transfer) refuses a frozen holder and moves nothingTest plan
Automated tests
CARGO_TARGET_DIR=<repo>/target SOROBAN_SDK_BUILD_SYSTEM_SUPPORTS_SPEC_SHAKING_V2=1 nix develop -c cargo test --locked -p async-vault— 327 tests pass, including the rewritten and new freeze and partial-freeze tests inlock_policy,complianceandwind_down.CARGO_TARGET_DIR=<repo>/target SOROBAN_SDK_BUILD_SYSTEM_SUPPORTS_SPEC_SHAKING_V2=1 nix develop -c cargo test --locked— full workspace, all crates pass.Manual verification
None. Checked
scripts/harness/for a frozen-holder call to a vault entrypoint: the only freeze scenario there unfreezes before calling the vault, and no entrypoint, event or error signature changed, so the harness needs no update and was not run against a local network.Breaking changes
Four exits that previously went through for a frozen holder now refuse with
Frozen: starting a redemption, claiming a priced one, cancelling a deposit, and a wind-down claim. A partial freeze no longer releases on the redeem escrow; it caps the request to the free balance instead. (claim_deposit's refusal while frozen already shipped in an earlier PR.)Checklist
Screenshots
None.