Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hpmaxi
marked this pull request as ready for review
October 17, 2026 14:50
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Governance swaps the vault's oracle under the same timelock as every other change, with no instant setter. It ships as a
VaultChange::Oraclechange on the shared queue (propose_change/apply_change) rather than separatepropose_oracle/apply_oracleentrypoints, so the console lists it with every other pending change.Changes
state()is never installedDeviations
propose_oracle/apply_oracleship as one change kind on the shared queue rather than as two new entrypointsbindings::VaultBindingClient(vault(),setup_open()), not the plan'stimelock::Bound, which does not exist in this basedocs/AUTHORIZATION_MATRIX.md§5.1's summary paragraph, for accuracyAcceptance criteria
state()is never installedTest plan
Automated tests
cargo test -p async-vault oracle_swap: 5 passed.cargo test -p async-vault: 364 passed.cargo test --locked(whole workspace): all green.Manual verification
None; no entrypoint signature, event or error the harness currently exercises changed (see report).
Breaking changes
None.
Checklist
Screenshots
None.