Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hpmaxi
marked this pull request as ready for review
October 17, 2026 16:46
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The harness never ran a wind-down, so the generated bindings never met the deployed Wasm on that path. This PR adds a wind-down run on a throwaway vault on the local network. It deploys a full vault set built from a
short_wind_downWasm, which drops the seven-day minimum and is never deployed elsewhere, takes it through a deposit, a redemption request, a wind-down and a claim, and checks that every function in the vault's spec is called through the generated client at least once.Changes
deploy.tsis split into reusable functions and exposesdeployThrowaway, which wires a full vault set from any vault Wasmclients.tsexposesconnectTo, so a test can connect to a deployment that was never written to diskwind-down.test.tssuite runs the wind-down scenario on the local network and checks every vault function is exerciseddocs/TESTING.mdandREADME.mddescribe the new suite and theshort_wind_downbuild it needsDeviations
.superpowers/sdd/2026-10-14-00-index/deferred/0004-ci-run-a-wind-down-on-a-throwaway-vault.patchfor the controller to apply, so "Runs in CI after the guards" is unchecked below until that lands.Acceptance criteria
Test plan
Automated tests
Manual verification
stellar contract build,CARGO_TARGET_DIR=target/short-wind-down stellar contract build --package async-vault --features short_wind_downandnpm run build:clients: runHARNESS_NETWORK=local npm run deploy -w scripts/harnessthennpm run test:wind-down -w scripts/harness. All 6 tests in "a wind-down on a throwaway vault" pass.npm run test:happy-path -w scripts/harness(24 tests) andnpm run test:guards -w scripts/harness(46 tests) still pass, confirming thedeploy.tsrefactor didn't change its behavior.Breaking changes
None.
Checklist
Screenshots
None.