Repository navigation
chore: modernize the repo toolchain and add E2E tests - #672
Merged
Merged
Conversation
Braintree pulls in WorkManager, which resolves to Room 2.6.1. Room 2.6's keep rule names no members, so R8 full mode dropped WorkDatabase_Impl's no-arg constructor and a minified release build crashed at startup with NoSuchMethodException. Ship a consumer ProGuard rule that keeps it.
The example app now has one button per scenario (pay, invalid token, two concurrent requests) and a status line the flows match on. Maestro flows cover launch, the invalid-token error, the concurrent-request guard and, with a Braintree sandbox key, cancelling the PayPal flow. Playwright checks the web build. A new E2E workflow runs them on release builds for iOS, Android and web.
nicolas-godefroy-dev
force-pushed
the
chore/repo-modernization
branch
from
November 12, 2026 07:17
ba874ee to
5453eac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes the repo's toolchain and adds end-to-end tests for the example app.
.tool-versions(mise).statusline that the E2E flows read.e2e.yml):android/consumer-rules.pro) keeps Room's database constructors, so minified release builds no longer crash at startup.Motivation
The old yarn, ESLint and husky setup was out of date, and nothing tested the native bridge automatically. Setting up E2E also exposed a startup crash in minified Android release builds: Braintree pulls in WorkManager, which resolves to Room 2.6.1. R8 full mode then removed
WorkDatabase_Impl's no-arg constructor, and the app crashed withNoSuchMethodExceptionbefore any JS ran.Testing
Jest,
tsc, oxlint and oxfmt pass locally. The Maestro and Playwright suites run ine2e.ymlon this PR. Thesandboxflow (cancelling the PayPal flow) needs thePAYPAL_SANDBOX_TOKENIZATION_KEYrepository secret and is skipped without it.Documentation