Repository navigation
Update REC, use REC:Wing and REC:ServiceShaft - #821
Merged
Merged
Conversation
|
The latest build of the Brick ontology on this PR is available here. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rec:Riserandrec:PlumbingRiserpatches. They were added in 1.5.0-rc2 and never shipped in a release.brick:Riseris now replaced by the existingrec:ServiceShaft(previouslyrec:Room). This matchesElevator_Shafttorec:ElevatorShaftandStaircasetorec:Stairwell.rec:Wingpatch now mirrors REC'sWing.json(Addition of new class Space:Wing and ODR. RealEstateCore/rec#257): it subclassesrec:SubBuildingand uses REC's comment. Remove it once REC 4.2 ships Wing in its SHACL distribution.recsubmodule to upstream main (v4.1.0-5-gc3984ed7). The SHACL files are unchanged.