Repository navigation
ci: migrate release build runner windows-2019 -> windows-2022 - #82
Merged
Merged
Conversation
GitHub removed the windows-2019 hosted runner image on 2025-06-30 (actions/runner-images#12045), so the deploy build job requesting it hangs forever at 'Waiting for a runner to pick up this job' and never publishes (e.g. the v2.0.6 release). windows-2022 is GitHub's recommended successor and is where the Node 26 win32 abi147 prebuild was verified to build (with the LTO-off env already on this job). Refs TM-3894
aborovsky
added
dependencies
alonchin
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate the
deploy.ymlrelease build job off the removedwindows-2019runner towindows-2022.Why
GitHub removed the
windows-2019GitHub-hosted runner image on 2025-06-30 (deprecation began 2025-06-01) — see actions/runner-images#12045. A job that still requestsruns-on: windows-2019is never assigned a runner: it hangs indefinitely atWaiting for a runner to pick up this job.... This is exactly what happened to the v2.0.6 release deploy (stuck ~1.5h with no runner), which blocks the npm publish of the Node 26 / ABI 147 build.Change
deploy.ymlbuild job:os: windows-2019→os: windows-2022(one line).windows-2022is GitHub's recommended successor and is the image on which the Node 26win32-x64abi147 prebuild was verified to build cleanly (the LTO-off env for the Node 26 LNK1117 issue is already on this job). No other change.Note
The already-cut v2.0.6 GitHub release was created from the tag before this fix, so its stuck deploy run won't retroactively recover — a re-run of that run (or the next release) on the fixed workflow will publish.
test.yml's Windows leg is already onwindows-2022(from #81); this was the lastwindows-2019reference in the repo.