Skip to content

fix: always serialize SQS fifoQueue #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VisualBean merged 1 commit into from
Oct 11, 2026
Merged

fix: always serialize SQS fifoQueue #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ByteBard.AsyncAPI.Bindings/Sqs/Queue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public void Serialize(IAsyncApiWriter writer)

writer.WriteStartObject();
writer.WriteRequiredProperty("name", this.Name);
writer.WriteOptionalProperty("fifoQueue", this.FifoQueue);
writer.WriteRequiredProperty("fifoQueue", this.FifoQueue);
writer.WriteOptionalProperty("deduplicationScope", this.DeduplicationScope?.GetDisplayName());
writer.WriteOptionalProperty("fifoThroughputLimit", this.FifoThroughputLimit?.GetDisplayName());
writer.WriteOptionalProperty("deliveryDelay", this.DeliveryDelay);
Expand Down
3 changes: 3 additions & 0 deletions test/ByteBard.AsyncAPI.Tests/Bindings/Sqs/SqsBindings_should.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ public void V2_SqsChannelBinding_WithFilledObject_SerializesAndDeserializes()
queueXPropertyName: queueXPropertyValue
deadLetterQueue:
name: myQueue_error
fifoQueue: false
deliveryDelay: 0
visibilityTimeout: 0
receiveMessageWaitTime: 0
Expand Down Expand Up @@ -276,6 +277,7 @@ public void V2_SqsOperationBinding_WithFilledObject_SerializesAndDeserializes()
sqs:
queues:
- name: myQueue
fifoQueue: false
deliveryDelay: 30
visibilityTimeout: 60
receiveMessageWaitTime: 0
Expand Down Expand Up @@ -312,6 +314,7 @@ public void V2_SqsOperationBinding_WithFilledObject_SerializesAndDeserializes()
x-queueExtension:
queueXPropertyName: queueXPropertyValue
- name: myQueue_error
fifoQueue: false
deliveryDelay: 0
visibilityTimeout: 0
receiveMessageWaitTime: 0
Expand Down
Loading