Skip to content

fix: use 'ws' as the WebSockets binding key #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VisualBean merged 1 commit into from
Oct 11, 2026
Merged

fix: use 'ws' as the WebSockets binding key #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ByteBard.AsyncAPI.Bindings/WebSockets/WebSocketsChannelBinding.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public class WebSocketsChannelBinding : ChannelBinding<WebSocketsChannelBinding>
/// </summary>
public AsyncApiJsonSchema Headers { get; set; }

public override string BindingKey => "websockets";
public override string BindingKey => "ws";

protected override FixedFieldMap<WebSocketsChannelBinding> FixedFieldMap => new()
{
Expand Down
2 changes: 1 addition & 1 deletion test/ByteBard.AsyncAPI.Tests/Bindings/WebSockets/WebSocketBindings_Should.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public void V2_WebSocketChannelBinding_WithFilledObject_SerializesAndDeserialize
var expected =
"""
bindings:
websockets:
ws:
method: POST
query:
description: this mah query
Expand Down
2 changes: 1 addition & 1 deletion test/ByteBard.AsyncAPI.Tests/Models/AsyncApiChannel_Should.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public void V2_AsyncApiChannel_WithWebSocketsBinding_Serializes()
{
var expected = """
bindings:
websockets:
ws:
method: POST
query:
properties:
Expand Down
Loading