Skip to content

INS-1745: Update NCCR 2026-10-06 (2) - #58

Merged
zdorman merged 4 commits into
devfrom
ins-1745-update-nccr-oct-2026
Oct 12, 2026
Merged

zdorman merged 4 commits into
devfrom
ins-1745-update-nccr-oct-2026

Conversation

@zdorman

@zdorman zdorman commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Update the submitted/curated inputs and processed outputs for the NCCR Data Platform datasets for INS.

Note: This is an intentional duplicate of #57, which was incorrectly merging with main

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Malformed DOI links and text artifacts propagate from the curated source into the production output.

3 open findings
What changed in this PR

Updates INS to use the October 6, 2026 NCCR dataset release.

Changes:

  • Adds eight curated NCCR dataset records and processed output.
  • Updates the configured NCCR version.
File Description
config.py Selects the new NCCR release.
data/​01_intermediate/​nccr/​2026-10-06/​nccr_datasets_curated.tsv Adds curated source records.
data/​02_output/​nccr/​2026-10-06/​nccr_datasets_curated_clean.tsv Adds standardized ingestion output.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread data/01_intermediate/nccr/2026-10-06/nccr_datasets_curated.tsv Outdated
Comment thread data/01_intermediate/nccr/2026-10-06/nccr_datasets_curated.tsv Outdated
Comment thread data/01_intermediate/nccr/2026-10-06/nccr_datasets_curated.tsv Outdated
- Fix doi url format
- Remove `?` artifact character
- Remove `Exit Disclaimer` copy/paste artifact

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Seven records contain narrative counts that conflict with their structured participant and sample counts.

5 open findings
3 resolved since last review

🧠 Review effort: Balanced

Comment thread data/01_intermediate/nccr/2026-10-06/nccr_datasets_curated.tsv Outdated
Comment thread data/01_intermediate/nccr/2026-10-06/nccr_datasets_curated.tsv Outdated
Comment thread data/01_intermediate/nccr/2026-10-06/nccr_datasets_curated.tsv Outdated
Comment thread data/01_intermediate/nccr/2026-10-06/nccr_datasets_curated.tsv Outdated
Comment thread data/01_intermediate/nccr/2026-10-06/nccr_datasets_curated.tsv Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread data/01_intermediate/nccr/2026-10-06/nccr_datasets_curated.tsv Outdated
Comment thread data/02_output/nccr/2026-10-06/nccr_datasets_curated_clean.tsv Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The curated data, generated output, deterministic UUIDs, and configured release version are consistent.

0 open findings

3 resolved since last review

🧠 Review effort: Balanced

@zdorman
zdorman merged commit 93a5475 into dev Oct 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants