Skip to content

INS-1714: Add DCTD Curated Datasets - #59

Merged
zdorman merged 5 commits into
devfrom
ins-1714-add-dctd-datasets
Oct 12, 2026
Merged

zdorman merged 5 commits into
devfrom
ins-1714-add-dctd-datasets

Conversation

@zdorman

@zdorman zdorman commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Add steps to process a curated TSV of datasets from the NCI Division of Cancer Treatment and Diagnosis Data Downloads through INS data packaging.

Use the final, processed TSV dctd_datasets_curated_clean.tsv for loading into INS.

- Follow convention for similar NCCR curated datasets
- Add DCTD to curated datasets sections
- Fix titles and links for NCCR and DCEG in curated dataset section

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Invalid TSV quote escaping corrupts a DCTD description in the final loading artifact.

3 open findings
What changed in this PR

Adds curated DCTD datasets to the INS packaging workflow.

Changes:

  • Adds DCTD configuration and packaging logic.
  • Adds 13 curated and processed datasets.
  • Updates documentation and dataset-type tests.
File Description
README.md Documents DCTD curation.
config.py Defines DCTD schema and paths.
modules/​package_output_data.py Packages DCTD datasets.
tests/​test_package_output_data.py Tests DCTD type mapping.
data/​01_intermediate/​dctd/​2026-10-01/​dctd_datasets_curated.tsv Adds curated source data.
data/​02_output/​dctd/​2026-10-01/​dctd_datasets_curated_clean.tsv Adds processed loading data.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread data/01_intermediate/dctd/2026-10-01/dctd_datasets_curated.tsv Outdated
Comment thread modules/package_output_data.py
Comment thread data/01_intermediate/dctd/2026-10-01/dctd_datasets_curated.tsv
- Remove unnecessary quotes causing escape issue

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The integration and generated UUIDs are consistent, with only minor description copy edits noted.

0 open findings

3 resolved since last review
Previously missed (4)

In code that hasn't changed since last review

Low severity Add missing article and hyphenate compound modifier

data/​01_intermediate/​dctd/​2026-10-01/​dctd_datasets_curated.tsv:8

The description is missing an article: “It is high-throughput amenable library” should read “It is a high-throughput-amenable library.” Correct the curated source and regenerate the clean TSV so the grammatical error is not loaded into INS.

Low severity Remove space before -supported compound modifier

data/​01_intermediate/​dctd/​2026-10-01/​dctd_datasets_curated.tsv:9

The space before “-supported” breaks the compound modifier in this user-facing description. Change “(OCCPR) -supported” to “(OCCPR)-supported” and regenerate the clean TSV.

Low severity Regenerate description after correcting missing article

data/​02_output/​dctd/​2026-10-01/​dctd_datasets_curated_clean.tsv:8

This generated description retains the missing article from the curated source: “It is high-throughput amenable library” should read “It is a high-throughput-amenable library.” Regenerate this file after correcting the intermediate TSV.

Low severity Regenerate artifact after fixing OCCPR-supported modifier

data/​02_output/​dctd/​2026-10-01/​dctd_datasets_curated_clean.tsv:9

The generated load artifact also contains the malformed “(OCCPR) -supported” modifier. Regenerate it after changing the curated source to “(OCCPR)-supported.”

🧠 Review effort: Balanced

@zdorman

zdorman commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

Low-priority issues noted in the last CoPilot review are valid finds but both are language decisions that reflect the source material. No change.

@zdorman
zdorman merged commit c13354b into dev Oct 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants