Repository navigation
Update the branch with recent changes from main - #51
Merged
Merged
Conversation
DATATEAM-739 deletion improvement
DATATEAM-777 update dependencies
update meval pyproject.toml
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
update github page
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and fixes across the model parsing, validation, loader, and workflow orchestration code. The most significant changes are the addition of support for resolving EDP (External Data Properties) terms in model parsing and workflows, improvements to node deletion logic in the loader, and the introduction of a new Prefect deployment for generating Pydantic models. There are also dependency updates and related test adjustments.
Model Parsing and EDP Resolution:
if_resolve_edpsparameter to theModelParserclass and related workflow functions, enabling optional resolution of EDP terms using the STS service. This allows users to fetch permissible value lists when required. Documentation and usage examples have been updated accordingly. (meval/parser.py,docs/pages/modelparser-usage.md,workflows/prefect/add_uuid_to_files.py,workflows/prefect/upsert_workflow.py,workflows/prefect/validate_submission_against_db.py) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Workflow and Deployment Enhancements:
get_pydantic_model) that generates a Pydantic model YAML for validation from S3-stored model files, with optional EDP resolution and S3 upload of the result. (prefect.yaml,workflows/prefect/get_pydantic_model.py) [1] [2]Loader Improvements:
delete_nodes_by_prop_valuemethod to first list all labels, perform indexed lookups per label, and delete deduplicated nodes in batches, improving performance and correctness. Updated related tests to reflect the new batching and label handling logic. (meval/loader.py,tests/test_loader.py) [1] [2] [3]Dependency and Compatibility Updates:
bento-mdfdependency from version 0.13.3 to 0.13.5 in bothpyproject.tomlandrequirements_python3.13.txt, and updated the project version to 1.2.2. (pyproject.toml,requirements_python3.13.txt) [1] [2] [3]Minor Cleanups and Test Adjustments:
meval/validator.pyand updated a static UUID in a test to reflect new namespace generation logic. (meval/validator.py,tests/test_validator.py) [1] [2] [3]These changes collectively improve the flexibility, performance, and maintainability of the codebase, especially around model parsing and data loading workflows.