fix(ep): fix approval request load and apprn handling - #597
Open
zubeydecivelek wants to merge 1 commit into
Open
fix(ep): fix approval request load and apprn handling#597zubeydecivelek wants to merge 1 commit into
zubeydecivelek wants to merge 1 commit into
Conversation
zubeydecivelek
commented
Sep 11, 2026
Comment on lines
+191
to
193
| # Consume the key even if the value is later dropped. | ||
| dojson_entry.pop(mapper.id, None) | ||
| return {k: v for k, v in metadata.items() if v} |
Contributor
Author
There was a problem hiding this comment.
If there's empty field we're having Unassigned metadata key error.
- {k: v if v} drops it from record.body["metadata"]
- Key still sits in dojson_entry
- Check thinks it’s unassigned
Comment on lines
+323
to
+329
| scheme = id_entry.get("scheme") | ||
| identifier = id_entry.get("identifier", "") | ||
| # apprn belongs only on the public record. | ||
| if scheme == "apprn": | ||
| removed.append(identifier) | ||
| continue | ||
| elif scheme != "cdsrn": |
Contributor
Author
There was a problem hiding this comment.
removed apprn from restricted record
zubeydecivelek
force-pushed
the
fix-ep-load
branch
from
September 11, 2026 09:05
643ad7a to
d7cef4d
Compare
zubeydecivelek
commented
Sep 11, 2026
Comment on lines
+152
to
+160
| # Parent access grants + communities before EP approval request | ||
| # (needs parent.communities.default for referee group lookup). | ||
| self.parent_load_cls( | ||
| restricted_entry, self.migration_logger, restricted_record_state | ||
| ).load(published_record=restricted_records[-1], uow=uow) | ||
|
|
||
| # 2. Create and approve EP approval request | ||
| approval_request_load.create(restricted_record_state, uow=uow) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
ApprovalRequestLoad needs parent.communities.default to pick the EP referee group. So it should be set before creating the request
zubeydecivelek
force-pushed
the
fix-ep-load
branch
from
September 11, 2026 13:57
d7cef4d to
9e9b46b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.