API: Eid sorting#42
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for sorting the /{etype}/get entity EID listing endpoint by entity ID (eid), and introduces API tests to validate ascending/descending ordering.
Changes:
- Extend sort parameter validation to accept the special pseudo-attribute
eid. - Map
eidsorting to the snapshot field (last.eid) when applying MongoDB sorting. - Add API tests covering
sort=eid:1andsort=eid:-1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
dp3/api/routers/entity.py |
Allows eid as a special sort key and maps it to last.eid for snapshot sorting. |
tests/test_api/test_get_entity_eids.py |
Adds tests for ascending/descending EID sorting (but introduces an import change that likely breaks test discovery). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…test for multi attr sort
xsedla1o
requested changes
Jul 14, 2026
xsedla1o
left a comment
xsedla1o
left a comment
Collaborator
There was a problem hiding this comment.
See comment. Otherwise looks good!
xsedla1o
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.