plugins types UPDATE pass ipv6 structure object#2530
Merged
Conversation
Give the object instead of the two fields to the str2ip functions. Signed-off-by: Jeremie Leska <jeremie.leska@6wind.com>
michalvasko
reviewed
Jun 19, 2026
michalvasko
left a comment
michalvasko
left a comment
Member
There was a problem hiding this comment.
What is the point of this PR since it is not changing the functionality?
Contributor
Author
|
Hi MIchal, As a reminder, this IPv6 address test would fail: However the previous PR was NBC. If this PR was accepted, I could have a simple unmerged patch with my dual_stack_format field. |
Member
Fair enough, I just wanted to know the reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give the object instead of the two fields to the str2ip functions.