Repository navigation
fix(memory): restore direct conversation extraction and subject attribution - #626
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct conversation facts were being dropped when structured attribution could not resolve transport identities, preferred names, companion sources, or non-speaking subjects. This restores extraction while preserving separate source and subject identities.
Validation:
npm run gate:pre-prpassed on933039041554e18e9b4c886b741f464bb749fe8e: build, typecheck, structural hygiene, 191 selected tests, 19,225 unit tests (5 skipped), and 850 integration tests. Focused regressions cover group alias rejection, unnamed mixed citations, first-mention non-creation, recurring semantic subject linking, and contact-tracking gates.Beads: psfn-framework-d5e0p.6, .7, .9, .10, .12. Acceptance wording for .7 and .12 now explicitly describes the stored name fields and existing recurring-mention threshold. Live validation remains pending deployment. Historical data repair, transcript re-extraction, and retrieval changes are separate work.