Make DeviceVarMtx recursive to avoid teardown self-deadlock - #1389
Open
zqb-all wants to merge 1 commit into
Open
Make DeviceVarMtx recursive to avoid teardown self-deadlock#1389zqb-all wants to merge 1 commit into
zqb-all wants to merge 1 commit into
Conversation
getOrCreateModule() holds DeviceVarMtx across compile(). If the backend exits the process during compile (e.g. the SPIR-V translator calls exit() on an invalid module), the atexit path deallocateDeviceVariables() re-locks DeviceVarMtx on the same thread and deadlocks.
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getOrCreateModule() holds DeviceVarMtx across compile(). If the backend exits the process during compile (e.g. the SPIR-V translator calls exit() on an invalid module), the atexit path deallocateDeviceVariables() re-locks DeviceVarMtx on the same thread and deadlocks.