Repository navigation
Conversation
…and count the coinbase's static bytes as 124 instead of 119.
… the binary parts in each job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #28, which is based on #24. Review the last commit. This is an alternative to #30: merge one of the two.
On BLAKE2b work every miner is served
COINBASE_TYPE_YUGE, and the coinbase never reaches the miner, so no firmware limit applies to its size. This raises it. Fingerprinting and classes 1, 2, 3 and 5 are unchanged.MAX_DICTATED_COINBASE_SIZEis 32000 (YUGE was 16000). That holds 1024 P2WPKH outputs or about 740 taproot outputs.datum_stratum_coinbase_fit_to_templatestill cuts the coinbase to the template's room. At the node's default-blockreservedweight(8000 WU) that is about 1800 bytes on a full block. Filling 32000 bytes needs about 129000 WU, 16% of an 800000 WU RDTS block.MAX_COINBASER_OUTPUTSis 1024 (was 512). It sets the coinbaser parse limit and the size ofavailable_coinbase_outputs.STRATUM_COINBASE2_MAX_LENis 65536 hex characters (was 32768).MAX_POW_MESSAGE_SIZE(MAX_COINBASE_TXN_SIZE_BYTES+ 4096) replaces 32768 as the size ofdatum_protocol_pow's message buffers and as the replay limit.DATUM_PROTOCOL_COINBASER_BUFFER_SIZEis 65536 (was 32768) for the coinbaser response, whose length field is a uint32.The pool server has to accept a share coinbase section (coinb1 + coinb2) of up to 31988 bytes, a share message of up to 33372 bytes (encrypted, with its pad), and a coinbaser response of up to 65535 bytes.
BSS goes from 89.4 MB to 130.4 MB.
The commit also reformats
datum_stratum.h: Allman braces, and spaces for alignment.Every commit builds with
-Wall -Werrorand passes--test.