Repository navigation
Fix officers/all response for legacy positions - #177
Closed
kathryntanardy wants to merge 4 commits into
Closed
kathryntanardy wants to merge 4 commits into
kathryntanardy wants to merge 4 commits into
Conversation
jbriones1
requested changes
Aug 27, 2026
jbriones1
left a comment
jbriones1
left a comment
Contributor
There was a problem hiding this comment.
I agree with your assessment that we should keep future inserts/updates using the positions we have defined.
jbriones1
requested changes
Aug 29, 2026
jbriones1
requested changes
Sep 10, 2026
jbriones1
left a comment
jbriones1
left a comment
Contributor
There was a problem hiding this comment.
Sorry, I keep waffling on this. Last one, I swear >.<
Contributor
There was a problem hiding this comment.
Suggested change
| position: str |
See below for reasoning
Contributor
|
@kathryntanardy I think this issue exposes a deeply rooted issue that we have a chance to address now since we'll be migrating our infrastructure. This means I can re-do our schema and prepare the data so this can be addressed properly. I'm going to pause this issue for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #159
Fix for the /officers/all 500 caused by legacy officer position values such as "elections officer". The Officer response model now treats position as a string, so old database values can be returned without being validated against the current OfficerPositionEnum. Write models still use the enum, so new create/update inputs remain strict.