fix: return empty election lists with HTTP 200 - #192
Closed
Gambit-Checkmate wants to merge 1 commit into
Closed
Gambit-Checkmate wants to merge 1 commit into
Gambit-Checkmate wants to merge 1 commit into
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #189.
[]whenGET /electionfinds no elections, both with and withoutwith_nominees=true.Both CRUD list functions already return sequences, so removing the empty-result exceptions lets the existing serialization produce an empty array. Database queries, authorization, and individual-election lookup behavior are unchanged.
Verification
Windows, Python 3.13.15, locked development/test dependencies. The local environment additionally uses
tzdatabecause Windows does not provide the system timezone database; no dependency or lockfile changes are included.python -m pytest tests/unit -q: 61 passed (existing baseline: 56 passed).ruff check .: passed.ruff format --check src/elections/urls.py tests/unit/test_elections.py: passed.git diff --check: passed.The new tests exercise the FastAPI router through HTTPX's ASGI transport with mocked database dependencies. PostgreSQL-backed integration tests were not run; no real database was connected or modified.
Opened as a draft following the project's PR checklist. Prepared with AI assistance.