Repository navigation
test: a second calendar seed for the refusals, and a join on a period (#451, 10.x) - #459
Merged
CaffeinatedCoder merged 2 commits intoOct 25, 2026
Merged
Conversation
…#451) - calendar-iso-week-53-of-a-52-week-year-rolls-over.patch lets the week check accept one week too many, so IsoWeek(2025, 53) rolls over to 2026-W01. It fails CalendarFactories_OverAnArgumentMemoryRefuses_RaiseInPostgres alone: the half of CalendarFactoryParityTests no seed proved. - CalendarFactories_AsAJoinKey_PairTheRowsMemoryPairs joins a date form against an integer form (Month, Quarter, Year) and requires the first and last periods to find a partner. E76's claim names the join; the docs already promised it. - The existing seed lost its doubled diff --git line, and its Fails line names the join, which it now also fails. `dotnet run tools/oracles.cs seeds calendar`: every seed is caught. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 23d9439)
CaffeinatedCoder
added
tests
This was referenced Oct 25, 2026
Closed
Closed
Base automatically changed from
docs/450-calendar-factory-wording-10.x
to
release/10.x
October 25, 2026 19:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #451
Cherry-pick (
-x) of #456 intorelease/10.x, for 10.3.0. It's stacked on #458 (#450's 10.x PR), because both edit claim E76 on adjacent lines, so merge #458 first.Closesdoesn't act on a release branch, so #451 is closed by hand once both PRs merge.Problem
CalendarFactoryParityTestshad one seed, and it proves only the extremes half. Nothing proved the refusal half,CalendarFactories_OverAnArgumentMemoryRefuses_RaiseInPostgres. That half is the one most likely to go vacuous: it accepts three SQLSTATEs, and itsWhereform passes if any row raises.docs/efcore.md#what-runs-wheresays "filter, join and sort by it", but no test covered a join.diff --gitline.Change
test/oracles/seeds/calendar-iso-week-53-of-a-52-week-year-rolls-over.patch(Oracles: CalendarFactoryParityTests). It changesweek <= weekstoweek <= weeks + 1in the ISO week check, soIsoWeek(2025, 53)rolls over to 2026-W01.CalendarFactories_AsAJoinKey_PairTheRowsMemoryPairs. It joinsMonth(x.Day)withMonth(y.Year, y.Month), and does the same forQuarterandYear. The pairs must equal memory's, and the rows atDateOnly.MinValueandMaxValuemust find a partner. E76's claim now names the join.Fails:line now names the join, which it also fails.Tests
Proven on
main(#456). Repeated here on PostgreSQL 16 with SDK 10.0.402:dotnet run tools/oracles.cs seeds calendarreportsevery seed is caught.🤖 Generated with Claude Code