Conversation
…reply Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…n on every state update) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trigger_exposure()setSEQ_WAIT_EXPOSEafter camerad's reply toexposeand the EXPOSING database write. The async listener clears that bit on the firstPIXELCOUNTand disarms. With EXPTIME 0 readout starts immediately, soPIXELCOUNTcan arrive before the set; the bit is then set with nothing left to clear it andsequence_startwaits on it forever. The set now happens before the command is sent.Example, 2026-09-08 UT, CAL_BIAS id 112442 (NEXP 7, EXPTIME 0):
Wait bits stayed EXPOSE READOUT. Every earlier bias in the logs cleared EXPOSE 28-45 ms after "waiting for exposure".
Second commit:
TargetInfomatched the integer keys withlike(OBSERVATION_ID like :obsid,SET_ID like :setid), which casts the column and defeats the primary key. EXPLAIN gives type=ALL, 93102 rows, for both the SELECT and the UPDATE inupdate_state, so the EXPOSING write above takes ~215 ms instead of ~1 ms; that is the whole race margin. Changed to=in the four conditions; EXPLAIN becomes const/range on PRIMARY, 1 row, with int or string binds.SET_NAME likeandSTATE likeunchanged.🤖 Generated with Claude Code