Skip to content

Add FITS header dictionary and wire it into the async writer - #10

Merged
mikelangmayr merged 10 commits into
mainfrom
mike/add-headers
Aug 25, 2026
Merged

mikelangmayr merged 10 commits into
mainfrom
mike/add-headers

Conversation

@mikelangmayr

@mikelangmayr mikelangmayr commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor
  • FrameMetadata carries two generic Common::FitsKeys blobs (header_set, frame_keys); FitsWriter emits both with no instrument-specific keyword knowledge
  • HISPEC's property dictionary lives in the instrument submodule instead (companion PR: hispec-tracking-camera-instrument#11)
  • key command, lifted from v1: adds custom FITS keywords via userkeys, no writer-side changes needed
  • datacube command, lifted from v1: writes one multi-extension FITS file per exposure (one image extension per read) instead of one file per read; each extension carries its own frame_keys plus a new WRTTIME
  • FrameOutput::end_exposure() finalizes the current cube when the exposure command ends (not by extension count); dropped the unused CadenceGate frame-rate throttle
  • Verified on real hardware on fei: headers, key, and datacube (including two separate exposures producing two separate cube files) all confirmed correct

Instrument-agnostic property->keyword/comment/default/enum table in
utils/fits_header_dictionary.*; FrameMetadata gains per-frame scalars
and a per-exposure header_set snapshot; FitsWriter emits both.
@mikelangmayr
mikelangmayr merged commit 13329e5 into main Aug 25, 2026
2 checks passed
@mikelangmayr
mikelangmayr deleted the mike/add-headers branch August 25, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants