Daemon and Python module become linkable libraries - #47
Open
astronomerdave wants to merge 1 commit into
Open
astronomerdave wants to merge 1 commit into
astronomerdave wants to merge 1 commit into
Conversation
core declares its own camerad and module only when top-level
astronomerdave
requested review from
mikelangmayr,
prkrtg and
scizen9
as code owners
October 5, 2026 18:35
Contributor
|
The library restructure is great! The second change removes the ability to have per instrument python packages, it would mean one python environment per instrument, for Hispec and possibly for future instruments this flexibility would be nice to have. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
required to meet camera 2.0 design
The daemon and Python module are now libraries,
camerad_daemonandcamerad_python, withcamerad::names. The core builds its owncameradand module only when top-level, and an instrument's build declares its own and links these.External libs moved onto libs that use them.
The module always imports as
camera_interface, one instrument per Python process. @mikelangmayr this meanspackage/trackingnow buildscamera_interfacetoo, so use one environemnt per instrument.This replaces PR #46 .
Verified locally with generic, hispec, and python.
CI jobs that check out submodules will continnue to fail for now.