Move vendored source to external and name the tracking module - #234
Merged
Merged
Conversation
Contributor
|
choice of |
…-extern # Conflicts: # etc/camera-interface
mikelangmayr
changed the title
Contributor
Author
|
@prkrtg Went with |
prkrtg
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
camera-interfaceandPIPythonintoexternal/, so vendored source lives in one place andetc/goes back to meaning configTrackingCamera.MODULE_NAMEtocamera_interface_tracking, the per-instrument package name, so two instrument builds can share one environmentpackaging/trackingexternal/camera-interface/packaging/tracking, which fixes the instrument and module name rather than passing them per installcamera_interface_trackingwhile the generic driver still selectscamera_interface, and that a missing module names the one it looked for