Repository navigation
Add datacube and an atomic guiding ROI keyword - #236
Merged
Merged
Conversation
prkrtg
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datacube, so a frame sequence can be written as one FITS cube. It is generic to any camerad camera, so it sits with the other generic keywordsguidingroi, which takes all four bounds as"y0 y1 x0 x1"and applies them in one step. Writing the four individual keywords re-derives and re-applies the whole camera mode each time, which is four detector reconfigurations and three intermediate geometries; this is one. The individual keywords stay, for reading and for nudging a single edgedatacuberound-trips,guidingroireads back the bounds in force and sets all four at once, and the validators reject bad arity and bad ordering. Four individual writes took 0.036s against 0.007s for oneguidingroi. pylint 10.00/10