Skip to content

Read the broker credentials from the environment instead of the URL - #244

Merged
mikelangmayr merged 1 commit into
mainfrom
mike/broker-credentials-from-env
Oct 3, 2026
Merged

mikelangmayr merged 1 commit into
mainfrom
mike/broker-credentials-from-env

Conversation

@mikelangmayr

Copy link
Copy Markdown
Contributor
  • HispecDaemon composes the broker URL from HISPEC_RABBITMQ_USER and HISPEC_RABBITMQ_PASSWORD, so the hostname stays in git and only the credentials live in /etc/hispec/secrets.env
  • Supplying credentials previously meant setting LIBBY_RABBITMQ_URL, which replaces the whole URL and so duplicated the hostname on every host
  • LIBBY_RABBITMQ_URL still works and still wins, for pointing one host at a different broker
  • Credentials are percent-encoded, so a password containing @ or / cannot break the URL apart
  • Docs updated, including an example that still showed the old DHCP address

@mikelangmayr
mikelangmayr merged commit e3e8fcf into main Oct 3, 2026
4 checks passed
@mikelangmayr
mikelangmayr deleted the mike/broker-credentials-from-env branch October 3, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants