Read the broker credentials from the environment instead of the URL - #244
Merged
Merged
Conversation
mikelangmayr
commented
Oct 2, 2026
Contributor
- HispecDaemon composes the broker URL from HISPEC_RABBITMQ_USER and HISPEC_RABBITMQ_PASSWORD, so the hostname stays in git and only the credentials live in /etc/hispec/secrets.env
- Supplying credentials previously meant setting LIBBY_RABBITMQ_URL, which replaces the whole URL and so duplicated the hostname on every host
- LIBBY_RABBITMQ_URL still works and still wins, for pointing one host at a different broker
- Credentials are percent-encoded, so a password containing @ or / cannot break the URL apart
- Docs updated, including an example that still showed the old DHCP address
prkrtg
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.