Repository navigation
Update IJK player SOs for H.264 output-format crop changes - #4264
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
Matching hashes do not establish build provenance or runtime behavior; the native builds were not independently reproduced, and exact-candidate dynamic-crop behavior remains unverified, requiring human review.
No open issues 🎉
What changed in this PR
This PR updates IJK player libraries to propagate H.264 visible dimensions when MediaCodec reports output-format changes. The reviewed documentation records the update’s provenance and validation limits, while distinguishing it from the v14 baseline build.
Changes:
- Documents source identity and player-library hashes for ARM64, ARMv7 and x86_64, with FFmpeg/SDL unchanged.
- Records static checks, playback results and device limitations, including the unverified dynamic-crop trigger.
- Adds notices to both build guides linking to the incremental update record.
| File | Description |
|---|---|
| doc/IJK_PR2_SO_UPDATE.md | Records update scope, provenance, hashes and validation boundaries. |
| doc/BUILD_SO.md | Adds a Chinese notice distinguishing the player update from the baseline build. |
| doc/BUILD_SO_EN.md | Adds the corresponding English notice and update-record link. |
Review effort: Balanced
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the ARM64, ARMv7 and x86_64
libijkplayer.socopies inex_soand the standalone modules to CarGuo/ijkplayer#2 (247dd7db9a59722137e586e7a1d077053e4b0a08). H.264 visible dimensions now propagate when MediaCodec reports an output-format change, including crop-only and one-axis changes.The six player files retain their original modes. FFmpeg/SDL bytes, legacy ABIs and RTMP remain unchanged. The source, SHA-256 values and validation boundaries are recorded in
doc/IJK_PR2_SO_UPDATE.md; experimental decoder-rebuild code is excluded.Validation:
c2.mtk.avc.decoderandc2.mtk.hevc.decoder(8.110 seconds each for eight-second clips). Earlier matching ARMv7 ordinary-playback and ARM64 cropped cold-start controls are retained in the validation record.git diff --checkpassed; both module layouts contain identical player bytes per ABI.Device limit: the Redmi emits the initial format event but no later crop-change event for the dynamic fixture, so it cannot demonstrate the dynamic trigger fixed by this PR. Ordinary fresh runs did not collect PNG pixel acceptance. Prior emulator software-MediaCodec validation is producer-reported; its original A/B logs were not supplied or rerun here. This update makes no claim of universal dynamic-crop support or 16 KiB page-device runtime certification.