Skip to content

Update IJK player SOs for H.264 output-format crop changes - #4264

Merged
CarGuo merged 1 commit into
masterfrom
codex/ijk-pr2-crop-so-20261104
Nov 5, 2026
Merged

CarGuo merged 1 commit into
masterfrom
codex/ijk-pr2-crop-so-20261104

Conversation

@CarGuo

@CarGuo CarGuo commented Nov 4, 2026

Copy link
Copy Markdown
Owner

Updates the ARM64, ARMv7 and x86_64 libijkplayer.so copies in ex_so and the standalone modules to CarGuo/ijkplayer#2 (247dd7db9a59722137e586e7a1d077053e4b0a08). H.264 visible dimensions now propagate when MediaCodec reports an output-format change, including crop-only and one-axis changes.

The six player files retain their original modes. FFmpeg/SDL bytes, legacy ABIs and RTMP remain unchanged. The source, SHA-256 values and validation boundaries are recorded in doc/IJK_PR2_SO_UPDATE.md; experimental decoder-rebuild code is excluded.

Validation:

  • Original PR sizing tests passed normal host compilation and ASan/UBSan execution.
  • All nine supplied library hashes and unchanged dependency Git blobs matched; three-ABI ELF/SONAME/player exports/imports and alignment were checked.
  • Fresh Redmi Android 13 ARM64 runs of these exact libraries completed H.264 and HEVC playback using c2.mtk.avc.decoder and c2.mtk.hevc.decoder (8.110 seconds each for eight-second clips). Earlier matching ARMv7 ordinary-playback and ARM64 cropped cold-start controls are retained in the validation record.
  • git diff --check passed; both module layouts contain identical player bytes per ABI.

Device limit: the Redmi emits the initial format event but no later crop-change event for the dynamic fixture, so it cannot demonstrate the dynamic trigger fixed by this PR. Ordinary fresh runs did not collect PNG pixel acceptance. Prior emulator software-MediaCodec validation is producer-reported; its original A/B logs were not supplied or rerun here. This update makes no claim of universal dynamic-crop support or 16 KiB page-device runtime certification.

Copilot AI balanced review requested due to automatic review settings November 4, 2026 11:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Matching hashes do not establish build provenance or runtime behavior; the native builds were not independently reproduced, and exact-candidate dynamic-crop behavior remains unverified, requiring human review.

No open issues 🎉

What changed in this PR

This PR updates IJK player libraries to propagate H.264 visible dimensions when MediaCodec reports output-format changes. The reviewed documentation records the update’s provenance and validation limits, while distinguishing it from the v14 baseline build.

Changes:

  • Documents source identity and player-library hashes for ARM64, ARMv7 and x86_64, with FFmpeg/SDL unchanged.
  • Records static checks, playback results and device limitations, including the unverified dynamic-crop trigger.
  • Adds notices to both build guides linking to the incremental update record.
File Description
doc/​IJK_PR2_SO_UPDATE.md Records update scope, provenance, hashes and validation boundaries.
doc/​BUILD_SO.md Adds a Chinese notice distinguishing the player update from the baseline build.
doc/​BUILD_SO_EN.md Adds the corresponding English notice and update-record link.

Review effort: Balanced

@CarGuo
CarGuo merged commit cae8e4f into master Nov 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants