Skip to content

Port SEQTaRget#173 fixes, plus further weighting and output fixes - #62

Merged
remlapmot merged 29 commits into
mainfrom
devel-2026-10-01
Oct 14, 2026
Merged

remlapmot merged 29 commits into
mainfrom
devel-2026-10-01

Conversation

@remlapmot

Copy link
Copy Markdown
Contributor

Ports the subset of fixes that were needed from CausalInference/SEQTaRget#173:

  • numeric fixed covariates stay continuous, weights no longer depend on the order of treatment_level,
  • excused-censoring weights and the excused-column direction are corrected,
  • each subject's first row is left out of the pre-expansion weight models,
  • subgroup bootstrap results are matched by name,
  • the end-of-follow-up eligible count is corrected, and
  • undefined model terms such as np.log(x) give an informative error.

Also fixes

  • the LTFU censoring weights (now P(remaining), as in SEQTaRget),
  • centred splines with glum offloading
  • bootstrap predictions with stateful terms
  • followup_spline with km_curves
  • collect() for subgroup analyses
  • weight_p99 overwriting the supplied bounds.

And

  • Adds Python 3.15 and tests on that.

Several of these change estimates, so have updated a few expected test values and the relevant vignette results.

remlapmot and others added 27 commits October 1, 2026 14:13
@remlapmot
remlapmot requested a review from ryan-odea October 13, 2026 10:37

@ryan-odea ryan-odea left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Tom, thanks! Might have to borrow your workaround for 3.15 inclusion in some other packages.

@remlapmot
remlapmot merged commit a04bc97 into main Oct 14, 2026
7 checks passed
@remlapmot
remlapmot deleted the devel-2026-10-01 branch October 14, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants