Repository navigation
feat: throttled live preview during Record + Z-Stack acquisitions - #592
Merged
hongquanli merged 5 commits intoSep 8, 2026
Merged
Conversation
Alpaca233
force-pushed
the
feat/record-zstack-acquisition
branch
from
July 27, 2026 21:30
0afae24 to
d07b875
Compare
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…orker Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…STACK_DISPLAY_FPS Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ings Review findings (sub-threshold but real): the _def.py comment said z-stack planes 'always display' while the next sentence says 0 disables both phases; and _on_frame's 'route + enqueue only' prose predated the preview tap. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…um rename #579's multi-plane recording (now merged into feat/record-zstack-acquisition) renamed RecordZStackAcquisitionParameters.recording_z_offset_um to recording_bottom_z_offset_um and added recording_Nz/recording_dz_um. The git merge of feat/record-zstack-acquisition didn't touch these two already-passing tests textually, so they kept constructing the params with the old keyword and failed after the merge.
hongquanli
force-pushed
the
feat/record-zstack-live-preview
branch
from
September 8, 2026 10:30
649295a to
c715519
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #564 (merges after it; rebase onto master if #564 lands squashed).
Shows frames in the live display during Record + Z-Stack acquisitions, which were previously display-blind:
StreamingCapture(display_fn+display_fps), first frame always shown, then atRECORD_ZSTACK_DISPLAY_FPS(default 3 fps,_def.py/INI;0disables preview for both phases).signal_new_imagecallback (previously wired to a no-op) now emits each captured plane.QtRecordZStackController.image_to_display, connected to the same display slots asmultipointController.image_to_displayin every display config (no double-fire — verified againstupdateNapariConnections's napariLiveWidget skip).streaming_capture.py/record_zstack_worker.py/record_zstack_controller.pygain only plain callables/floats;Signalappears only ingui_hcs.py. Headless path unchanged (defaultsNone/0).Testing
QT_API=pyqt5).Design:
AI-docs/Squid/to-do/2026-07-06-record-zstack-live-preview-design.md🤖 Generated with Claude Code