Skip to content

Fix GitHub Actions: Prevent Command Injection in Firefox Workflow #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PeterDaveHello merged 1 commit into from
Aug 2, 2026
+10 −2
Merged

Fix GitHub Actions: Prevent Command Injection in Firefox Workflow #989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/firefox-metadata.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_dispatch:
inputs:
version:
description: "Firefox version to update, for example 2.6.1"
description: "Firefox version to update, for example 2.6.1 or 2.4.5.1"
required: true
type: string

Expand All @@ -27,8 +27,16 @@ jobs:
run: npm ci

- name: Update Firefox metadata
run: npm run release:update-firefox-metadata -- --version "${{ inputs.version }}"
shell: bash
run: |
if [[ ! "$FIREFOX_METADATA_VERSION" =~ ^(0|[1-9][0-9]{0,8})(\.(0|[1-9][0-9]{0,8})){2,3}$ ]]; then
echo "Firefox version must use x.y.z or x.y.z.w numeric format without leading zeros" >&2
Comment on lines +32 to +33

@qodo-code-review qodo-code-review Bot Aug 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

1. Long bash lines over 100 📘 Rule violation ⚙ Maintainability

The added Bash validation step includes lines that exceed 100 characters, violating the repository
line-length requirement. This can reduce readability and may conflict with formatting/linting
expectations for changed files.
Agent Prompt 
## Issue description
New/modified lines in the workflow exceed the 100-character maximum line length.

## Issue Context
The `if [[ ... =~ ... ]]` regex and the `echo` error message are each on a single long physical line. The compliance rule requires each physical (non-comment, non-whitespace) line to be 100 characters or fewer.

## Fix Focus Areas
- .github/workflows/firefox-metadata.yml[32-33]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

exit 1
Comment thread
PeterDaveHello marked this conversation as resolved.
fi
Comment thread
qodo-code-review[bot] marked this conversation as resolved.

npm run release:update-firefox-metadata -- --version "$FIREFOX_METADATA_VERSION"
env:
FIREFOX_METADATA_VERSION: ${{ inputs.version }}
FIREFOX_EXTENSION_ID: ${{ secrets.FIREFOX_EXTENSION_ID }}
FIREFOX_JWT_ISSUER: ${{ secrets.FIREFOX_JWT_ISSUER }}
FIREFOX_JWT_SECRET: ${{ secrets.FIREFOX_JWT_SECRET }}