fix(security): harden open proxy fallback against SSRF and key leak - #6859
Closed
Solaris-star wants to merge 1 commit into
Closed
fix(security): harden open proxy fallback against SSRF and key leak#6859Solaris-star wants to merge 1 commit into
Solaris-star wants to merge 1 commit into
Conversation
The fallback proxy accepted any x-base-url without auth and used a substring check for api.openai.com, allowing unauthenticated SSRF and server API key exfiltration via attacker hosts containing that string. Require auth like other providers, parse x-base-url as a real URL, block private/loopback/CGNAT/metadata hosts, and only inject the server OpenAI key when the hostname is exactly api.openai.com. Fixes #6813 Fixes #6814 Signed-off-by: Solaris-star <820622658@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The open proxy fallback (
app/api/proxy.ts) had two related issues:x-base-urlto an arbitrary URL (including internal/metadata hosts) and the server would fetch it.baseUrl.includes("api.openai.com")injected the server OpenAI key for attacker hosts such ashttp://attacker.com?q=api.openai.com.Changes
auth()like other provider handlersx-base-urlwith the URL constructor (http/https only)100.64/10, metadata-ish hosts)hostname === "api.openai.com"Testing
Fixes #6813
Fixes #6814