fix: alibaba secret validation should not run when disableValidation is true - #394
Open
cx-diogo-rocha wants to merge 1 commit into
Open
fix: alibaba secret validation should not run when disableValidation is true#394cx-diogo-rocha wants to merge 1 commit into
cx-diogo-rocha wants to merge 1 commit into
Conversation
cx-julio-silva
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Proposed Changes
When we introduced custom rules we gave support to disable validation on custom Queries. At the time our change only supported disabling validation for rules in ruleIDToFunction map.
This PR change allows to also disable validation for rules in the alternative flow that goes through !v.pairsCollector.addIfNeeded (currently only alibaba rules fall on this flow)
Checklist
I submit this contribution under the Apache-2.0 license.