Skip to content

Fix ISellectionCollection.Select failing on large child selection sets - #10655

Merged
tobias-tengler merged 4 commits into
mainfrom
tte/fix-selection-collection-capacity
Oct 21, 2026
Merged

tobias-tengler merged 4 commits into
mainfrom
tte/fix-selection-collection-capacity

Conversation

@tobias-tengler

Copy link
Copy Markdown
Member

No description provided.

Copilot AI balanced review requested due to automatic review settings October 21, 2026 11:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@tobias-tengler tobias-tengler changed the title Fix ISellectionCollection.Select throwing or hanging when many fields match Fix ISellectionCollection.Select failing on large child selection sets Oct 21, 2026
@tobias-tengler
tobias-tengler merged commit b7bd736 into main Oct 21, 2026
158 checks passed
@tobias-tengler
tobias-tengler deleted the tte/fix-selection-collection-capacity branch October 21, 2026 12:08
@github-actions

Copy link
Copy Markdown
Contributor

Patch coverage

85.7% of changed lines covered (6/7)

File Covered Changed Patch %
…/Core/src/Types/Execution/Processing/SelectionCollection.cs 6 7 85.7% 🟡
Uncovered changed lines (JSON)
{
  "sha": "edb40669c1a59d9939ab7ee5153cd29f13f23617",
  "files": [
    { "path": "src/HotChocolate/Core/src/Types/Execution/Processing/SelectionCollection.cs", "ranges": [[67, 67]] }
  ]
}

Project coverage: 59.2% (313442/529768 lines)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants