Keep audio playback attached to its original recording - #2887
Chris0Jeky merged 2 commits into
Conversation
|
Bounded independent Luna review of the playback diff at7222855c6 found no direct HIGH/CRITICAL defect. Request ID, source generation and recording ID prevent stale success/error/cleanup from altering a newer receipt; invalidation revokes object URLs. Full frontend6403pass/3skip,16focused,typecheck/build/ESLint and the17.1s controlled-response Chromium journey pass. Documentation-only qualification commit706685b29 follows the reviewed runtime. No additional review loop requested. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
e6da15a
into
codex/2808-overhaul-followthrough
1 participant
An original audio download can finish after the shared question changes. Playback now binds every response to its recording ID and source/request generations, revokes stale object URLs, and prevents old success/error/cleanup from changing a newer request. Current-receipt loading and source readiness gate playback.
Continues #2808; fixes the confirmed MEDIUM race described on #2866 (comment3975407612). Stacked on #2886, preserving Classic, Studio, Companion and Unified.
Validation: 16 focused component tests, typecheck, production build and scoped ESLint passed. Full frontend: 6,403 passed, three existing skips,414files. Chromium passed17.1s with a controlled stalled original response, question replacement/revert, playback recovery, lost-upload receipt retry, explicit confirmation, experience switching and narrow-screen accessibility. One bounded independent Luna review found no HIGH/CRITICAL defect. Docs links/governance/diff checks passed.
No backend behavior changed. Hosted qualification remains required; real microphone/provider/physical-device and release acceptance are not claimed. Existing OUTSTANDING_TASKS.md owner decisions remain open. Detailed evidence: docs/product/WORKSPACE_OVERHAUL_VALIDATION.md and C:/Taskdeck-overhaul/evidence/audio-playback-*.