Keep retained Review health scoped to visible board data - #2929
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Independent fresh-context review at 727183c: SHIP, no confirmed HIGH or MEDIUM findings. The reviewer checked visible-board attribution and preservation of current request counters, and verified a clean frozen checkout/diff. Test execution remains the author's recorded 199 focused and 6,462 full frontend passes, three skips. Source is frozen. Exact-head hosted CI and current-base qualification remain pending; #2924's separate recovery fix will be reconciled before merge. Logs are preserved at C:\Users\Public\codex-shell-home\taskdeck-alpha-evidence\2923, and the completed worktree is being removed. OUTSTANDING_TASKS.md human release/private-deployment/manual acceptance gates remain open. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 727183c201
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…covery Clear recovery announcements when retained Review warnings return
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 827488d8ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
A freshly fetched board C hash target could inherit board B's retained warning after a failed scope change. Revealing an older warning could also overwrite newer failure counters, delaying the refusal disclosure.
The restoration now checks the visible rows' board and restores only the retained disclosure flags. Current request counters continue unchanged. Two real-Vue regressions reproduce both defects before the fix and cover the repaired transitions.
Validation: focused 199 tests pass; full frontend passes 6,462 tests with three existing skips. Typecheck, production build and scoped lint pass. Governance and diff checks pass. No new browser run: the changed contract is state attribution, proven through the actual Vue watchers; prior #2918 browser evidence covers the unchanged rendering. No backend change.
Canonical docs: no strategy or delivery-status edit in this follow-up; the issue receipt carries the precise residual closure. #2921 separately retires recovery announcements when a retained warning returns.
Closes #2923
Review: independent pass is clean. Two connector MEDIUM findings are dispositioned and tracked in #2930: fresh hash rows can still inherit unscoped health, and a later detour can misattribute preserved request counts. Neither affects proposal data or authority.
Current-base qualification: after #2924 merged as 3105aed, integrated at 827488d. The overlap keeps recovery retirement and current-counter preservation together. All 201 focused tests, typecheck, build and scoped lint pass; independent integration review is clean. Hosted CI is rerunning for this head.