Exclude archived cards from import and proposal WIP counts - #2951
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Independent adversarial review of exact head 5ca0772: SHIP, no findings. The review traced import preview/apply ordering, unchanged controller authorization, full-card repository loads and both proposal count displays. Red 4 failed/2 passed; focused 65 passed; full backend 9,390 passed with five existing skips. Hosted CI remains pending. No browser or schema change. |
|
Implementation worktree removed after confirming the committed head matches origin and inventorying ignored files. Red/green/full-backend logs and cleanup inventory are preserved at C:\Users\Public\codex-shell-home\taskdeck-alpha-evidence\2944. Only generated bin/obj artifacts were discarded. Primary checkout retains its unrelated bash.exe.stackdump; no user changes were altered. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad3780f8ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Current-base integration at ad3780f includes main be0e134. The only inbound change is the five-file Batch Apply announcement slice from merged #2948; this PR's implementation files are unchanged. Independent scoped review of that exact inbound delta returns SHIP: no effect on Inbox polling, card type/comment state, or backend WIP behavior, and no change to confirmation/Apply gating. Delta artifact SHA-256 B0E695DBAD9BA4AEF0BB8F78832A783C1D1749FA02A9565FEF346C717FF24021. Earlier original/fix reviews remain valid. Fresh hosted CI is running; not yet merge-qualified. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00828293f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Current-base qualification: integrated main fad4935 (#2945) at head 0082829. The inbound 29-file Inbox delta is disjoint from this PR's owned changes. Independent scoped interaction review found no blocker: status polling remains read-only and does not alter proposal or board writes. Existing source review and local proof remain applicable. Fresh exact-head hosted CI is pending; this comment does not qualify a pending gate as passed. |
|
Current-base qualification at a5664d6: merged main7695211a0d31590c19845fd0e4cd559be521384e (#2949). Independent scoped review found no interaction blocker. The inbound 41-file type payload is byte-identical across the four Alpha candidates (SHA2566F80C8B1197DCDB73E63FF728DAF14A65645B1B2D2767DB410E95F57A7D95EBF), and this PR's owned paths are disjoint. Original source review stands; this was a read-only source/diff interaction pass, not new test execution. Fresh exact-head hosted CI remains required and pending. |
|
Current-base qualification at d2bde7e: merged main 93ca1cd. The added payload is exactly #2957's WorkspaceObservationReader.cs and WorkspaceObservationApiTests.cs changes. Independent scoped interaction review confirms the original PR diff is unchanged and found no direct interaction defect. Normalized binary diff SHA-256 matches main's landed payload: 4ABA3D6CE91FDC934ED93418723239C8FAF4C6B86DBA2200349C4BBCFCB6F2DE. No local tests were repeated for these disjoint paths. Fresh exact-head hosted CI remains pending; this is not yet merge qualification. |
|
Current-base qualification at 8015a84 integrates landed hierarchy main 86c6f1b. All four WIP feature files are byte-identical to reviewed d2bde7e. Independent guarded interaction review preserves SHIP: archive/delete detach leaves active children active and counted, while archived parents remain excluded; hierarchy tokens/parent links do not change this count projection. The existing #2926 MEDIUM remains tracked. ExternalImportServiceTests + ProposalConflictDetectorTests: 65 passed at the current head. Fresh hosted CI remains pending. No new feature or fix round was started. |
|
The current-head hierarchy interaction suite also passes: 17 API contract/concurrency tests at 8015a84. Temporary qualification worktree removed after clean/ignored-output inventory. Logs are preserved at C:/Users/Public/codex-shell-home/taskdeck-alpha-evidence/2944/{hierarchy-base-tests,hierarchy-interaction-tests}.log. Hosted CI remains the merge gate. |
1 participant
Archived cards were counted against active WIP limits during external import and proposal conflict checks. An archived-only column could reject a new active card, and import dry runs could report success for an apply that would exceed the limit.
Count active cards in both paths. Import dry runs now perform the same capacity check as apply before returning, while remaining read-only. Regression cases cover archived-only and mixed columns, rejection without writes, and proposal warning/capacity text.
Closes #2944.
Validation:
No browser behavior or schema changes. Archive-match import semantics (#2935) and cumulative restore preview (#2926) remain separate.