Skip to content

Recover card permissions from fresh committed board payloads - #3055

Merged
Chris0Jeky merged 5 commits into
mainfrom
codex/3049-permission-payload
Sep 12, 2026
Merged

Chris0Jeky merged 5 commits into
mainfrom
codex/3049-permission-payload

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

After a denied card write, a fresh board-detail response could repeat canWrite: true without clearing the editor's recovery lock. Track board-detail request and committed-payload generations so only a server read begun after denial can restore editing. Local same-valued replacements and pre-denial in-flight reads remain locked, and obsolete reconciliation is cancelled.

This restores editing without discarding drafts or adding reads to ordinary known-permission paths. Failed, denied or omitted permission still grants nothing. The change stays within the existing shared card permission and board-detail store boundary.

Validation:

  • The old boolean-only implementation fails the local-replacement characterization.
  • Final focused permission/store specs: 100 passed.
  • Full frontend on the merged main base: 6,794 passed, 3 existing skips across 438 files.
  • Typecheck and production build passed before the test-only fixture follow-up.
  • One independent review identified missing refs in an existing partial store mock. The four-line fixture/lifecycle repair was separately reviewed clean; runtime source was unchanged by that repair.
  • Documentation links, docs governance and git diff --check pass. STATUS and MASTERPLAN record the candidate and its qualification limits.

Hosted CI will qualify the exact final head. Live browser permission transitions and physical-device/screen-reader acceptance were not rerun. Existing human actions remain in OUTSTANDING_TASKS.md; no hosting or authority changes are included.

Closes #3049

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-12T17:07:12.254325Z 87adafe PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Chris0Jeky Chris0Jeky moved this from Pending to Review in Taskdeck Execution Sep 12, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87adafe6c8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/taskdeck-web/src/composables/useCardTypePermission.ts
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Reviewed source commits are now included in integration PR #3054 at 51e12925c381991c04bc458535d22afd7eefd200, without conflict-resolution edits. Source proof and review remain recorded here; the integration adds 106 passing focused panel/permission/store tests and will receive exact-head hosted qualification. Merge through #3054 preserves the source history and avoids serial base-change qualification. Do not merge or delete this source branch independently while that gate is running.

@Chris0Jeky
Chris0Jeky merged commit 777176a into main Sep 12, 2026
36 checks passed
@Chris0Jeky
Chris0Jeky deleted the codex/3049-permission-payload branch September 12, 2026 19:36
@github-project-automation github-project-automation Bot moved this from Review to Done in Taskdeck Execution Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Recover denied card editor from a fresh same-valued board permission payload

1 participant