Persist proposal webhook deliveries before commit - #3071
Merged
Merged
Conversation
…24-webhook-transactional-stage
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
# Conflicts: # docs/STATUS.md
This was referenced Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A host failure after a proposal committed but before notification completed could permanently lose its webhook delivery. Already-buffered proposal events now stage filtered Pending delivery rows before the final proposal save, so board effects, audit/status receipts, subscription trigger timestamps and delivery rows commit or roll back together. After commit, realtime publication remains best-effort and the existing webhook worker can recover the committed queue rows.
The change reuses the current outbound delivery queue and retry worker. It adds no schema or migration. Immediate notification producers and the separate assignment collector retain their current behavior; the scope is the executor's already-deferred lifecycle, card-update, detached-child and relation events. Explicit review, approval and Apply remain required.
Validation:
Delivery remains at-least-once under the existing worker contract. Controlled callback loss is not an actual process-kill test; external HTTP delivery, physical-device/screen-reader acceptance and release/hosting decisions were not exercised. OUTSTANDING_TASKS.md remains unchanged.
This PR is stacked on #3066 through7c66104b3900a7d9bb44153b299f714e86d34cdd, including its corrected chat ID/revision contracts and delivered archive draft settlement from main9a8c14c6b. The latest base merge changes frontend/docs only; backend files are unchanged from the previous combined webhook/chat head. The parent passes61 focused archive/relation tests on this base. Merge that parent first, retain its branch until this child is retargeted, and requalify the new base. The source and SQLite proof commits are preserved. The finished proof worktree was removed only after remote/ancestry verification; its red/green TRX files, logs and restoration receipt remain at C:/td0912-evidence/webhook-durability-control.
Closes #3024