Qualify capture LF normalization to linked transcripts - #3097
Open
Chris0Jeky wants to merge 2 commits into
Open
Chris0Jeky wants to merge 2 commits into
Chris0Jeky wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close the final wording residual left after #2933. Capture reconciliation compares line endings without rewriting stored source text, but only linked-transcript correction normalizes the queue projection to LF. Ordinary suggestion edits preserve submitted bytes.
This change narrows both the helper comment and the public capture API guide to that actual boundary. It keeps the already-delivered durable/legacy export field contract and the six direct
CaptureTextComparisoncases unchanged.Scope and behavior
CaptureTextComparison.Equivalentremains byte-significant apart from line-ending normalization.durableCapture.sourceAssets[].text; queue fallback remainslegacySource.textonly when no durable capture exists.main: the helper explanation anddocs/api/CAPTURE.md.Verification
Exact head:
5b70d1f5ca7a73d15538f882af48c70b831d2107.34911547906: success.34911548088: success.34911548083: all 18/18 jobs are terminal with no failure, queued, in-progress, or null-conclusion job. The GitHub Actions parent run still reportsin_progress, which is a workflow-finalization/API lag rather than an executing or failed job.No local execution result is claimed from this connector environment; the evidence above is the exact hosted head.
Closes #2912