Warn when telemetry consent cannot be saved - #3100
Draft
Chris0Jeky wants to merge 9 commits into
Draft
Chris0Jeky wants to merge 9 commits into
Chris0Jeky wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Fixes the GH-2913 privacy-control defect where a telemetry opt-out could take effect only in memory while a stale persisted
truevalue silently enabled telemetry again after reload.Taskdeck still applies the user's current choice immediately and privacy-first:
If
localStoragerefuses the preference write, Taskdeck now leaves a persistent warning receipt explaining that the current-session choice worked but may not survive reload. The same warning contract covers an opt-in that exists only in memory.Implementation
telemetryStore.tstoastStoretelemetryStore.consent.spec.tsCOOKIE_POLICY.md,OBSERVABILITY_SETUP.md, andobservatory/README.mdTDD / verification boundary
The focused tests were committed before the implementation change. The resulting suite contains seven consent-ownership cases.
These are supplied regressions, not a claimed local passing result. This connector session has no executable current-main checkout or restored Node 24 dependency tree, so it did not run Vitest, typecheck, build, docs governance, or link checks locally. Keep the PR draft until exact-head hosted qualification completes.
Expected focused command:
cd frontend/taskdeck-web npx vitest --run --maxWorkers=2 src/store/telemetryStore.consent.spec.ts npm run typecheck npm run buildDocumentation checks:
Scope and residuals
ProfileSettingsView.vueis intentionally unchanged: the checkbox already callstelemetry.setConsent, and the existing global toast host provides the persistent receipt without duplicating a settings-only error channel.Part of GH-2913.