Stabilize generated E2E identity width - #3101
Open
Chris0Jeky wants to merge 3 commits into
Open
Chris0Jeky wants to merge 3 commits into
Chris0Jeky wants to merge 3 commits into
Conversation
Chris0Jeky
marked this pull request as ready for review
September 15, 2026 01:23
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Take the first independent visual-stability residual from #2764. The shared E2E auth helper emitted a random username segment between one and six digits, so otherwise identical account text changed width between runs and consumed screenshot-diff tolerance.
The implementation zero-pads that random segment to six digits. Timestamp entropy and the existing scope prefix remain unchanged, so worker/test isolation is preserved.
Red → green evidence
The original test harness commit
638bf177effce0395d05634e2e99aed5d527cd35imported an E2E-only module into the browser tsconfig and failed typechecking onprocess; that was a fixture defect and is not counted as the behavior red.RED — exact corrected test-only head. Commit
485bbf46d532773d92fe1fa3b9140d020041cebbreads the helper as raw source, keeping production untouched. CI run34913155677passed frontend lint, typecheck, build, and PWA validation, then both frontend operating-system jobs (104205621086,104205621146) failed the focused assertion. The archived JUnit receipt identifies onlye2eAuthIdentity.spec.ts: the source still containedMath.floor(Math.random() * 1_000_000)and lacked the required.padStart(6, '0')contract.GREEN — exact hosted head. Commit
6ec09d5e7e5412f23d4f3cec2e9b17e45ec8cf6dchanges the shared helper by one expression.34914006798: success.34914006984: success.34914006968: success.Scope
.gitattributeswork remain open.Refs #2764