Skip to content

Stabilize generated E2E identity width - #3101

Open
Chris0Jeky wants to merge 3 commits into
mainfrom
codex/2764-fixed-width-e2e-identities
Open

Chris0Jeky wants to merge 3 commits into
mainfrom
codex/2764-fixed-width-e2e-identities

Conversation

@Chris0Jeky

@Chris0Jeky Chris0Jeky commented Sep 15, 2026

Copy link
Copy Markdown
Owner

Purpose

Take the first independent visual-stability residual from #2764. The shared E2E auth helper emitted a random username segment between one and six digits, so otherwise identical account text changed width between runs and consumed screenshot-diff tolerance.

The implementation zero-pads that random segment to six digits. Timestamp entropy and the existing scope prefix remain unchanged, so worker/test isolation is preserved.

Red → green evidence

The original test harness commit 638bf177effce0395d05634e2e99aed5d527cd35 imported an E2E-only module into the browser tsconfig and failed typechecking on process; that was a fixture defect and is not counted as the behavior red.

RED — exact corrected test-only head. Commit 485bbf46d532773d92fe1fa3b9140d020041cebb reads the helper as raw source, keeping production untouched. CI run 34913155677 passed frontend lint, typecheck, build, and PWA validation, then both frontend operating-system jobs (104205621086, 104205621146) failed the focused assertion. The archived JUnit receipt identifies only e2eAuthIdentity.spec.ts: the source still contained Math.floor(Math.random() * 1_000_000) and lacked the required .padStart(6, '0') contract.

GREEN — exact hosted head. Commit 6ec09d5e7e5412f23d4f3cec2e9b17e45ec8cf6d changes the shared helper by one expression.

  • Smart CI Self-Test run 34914006798: success.
  • CI Extended run 34914006984: success.
  • Main CI run 34914006968: success.
  • The exact-head matrix covers frontend tests on Ubuntu and Windows, E2E smoke, API integration on both operating systems, backend and CLI tests, container/backup verification, migrations, security, architecture, docs governance, production/PWA build, and source-launcher checks.

Scope

Refs #2764

@Chris0Jeky
Chris0Jeky marked this pull request as ready for review September 15, 2026 01:23
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-15T01:26:07.262081Z 6ec09d5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending

Development

Successfully merging this pull request may close these issues.

1 participant