Skip to content

Centralize recorded-operation fallback formatting - #3103

Open
Chris0Jeky wants to merge 4 commits into
mainfrom
codex/1434-recorded-operation-residuals
Open

Chris0Jeky wants to merge 4 commits into
mainfrom
codex/1434-recorded-operation-residuals

Conversation

@Chris0Jeky

@Chris0Jeky Chris0Jeky commented Sep 15, 2026

Copy link
Copy Markdown
Owner

Purpose

Take two bounded presentation residuals recorded after #2729 without reopening the already-delivered Paper/Legacy parity work.

This slice:

  • makes malformed legacy actionType values degrade to empty presentation copy instead of throwing;
  • moves applied decision records onto the shared recorded-operation formatter, including its archive/restore lifecycle wording, rather than maintaining a third regex copy.

Red → green evidence

RED — exact test-only head. Commit 33ead2aaba85efd9f1be7f741b116832d8e63cce added the focused regressions before production changed. CI run 34913696668, Windows frontend job 104206634868, passed lint, typecheck, build, and PWA validation, then failed the frontend test phase on the intended boundaries:

  • undefined raised Cannot read properties of undefined (reading 'toLowerCase');
  • the applied record rendered archive lifecycle · card instead of archive · card.

That first test-only pass also pinned a duplicate supporting-note sentence. The implementation connector could not safely patch that large orchestrator without replacing the entire file, so commit 85d211c8d3e8affefb5e82ec41a3b03f2b06ce10 narrows the regression suite to the two source-level residuals rather than risking unrelated churn. The duplicate-note copy remains explicitly open.

GREEN — exact hosted head. Commit 85d211c8d3e8affefb5e82ec41a3b03f2b06ce10 contains the shared formatter guard, the applied-record consolidation, and the focused tests.

  • Smart CI Self-Test run 34914268771: success.
  • CI Extended run 34914268968: success.
  • Main CI run 34914269002: success.
  • Later redundant CI Extended reruns on the same SHA do not change the successful exact-head evidence above; two were concurrency-cancelled and one remains a non-required rerun.

Scope

Refs #1434

@Chris0Jeky Chris0Jeky changed the title Consolidate recorded-operation fallback presentation Centralize recorded-operation fallback formatting Sep 15, 2026
@Chris0Jeky Chris0Jeky added Priority IV Later maturity/deepening; revisited at horizon planning. testing Test coverage, harnesses, regression prevention, and verification pipeline work. labels Sep 15, 2026 — with ChatGPT Codex Connector
@Chris0Jeky
Chris0Jeky marked this pull request as ready for review September 15, 2026 01:15
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-15T01:18:03.251336Z 85d211c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Chris0Jeky Chris0Jeky left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fresh-context review: no merge-blocking presentation or compatibility finding on this head.

The shared formatter now fails soft on malformed legacy values without mutating stored operations. Trimming before normalization prevents whitespace-only labels and preserves the existing lifecycle aliases; ordinary camel/snake/kebab values still use the established transformation. The applied decision record removes its third local formatter and uses the same lifecycle vocabulary as Paper and shared display-name paths.

The fallback still emits the localized not recorded value when both action and target are absent, rather than producing a dangling separator. Exact-head Required CI, CI Extended, and Smart CI are completed successfully. The duplicate supporting note and Create Card Card cosmetic remain honestly outside this slice under #1434. This PR is ready for maintainer review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority IV Later maturity/deepening; revisited at horizon planning. testing Test coverage, harnesses, regression prevention, and verification pipeline work.

Projects

Status: Pending

Development

Successfully merging this pull request may close these issues.

1 participant