Do not treat pinch zoom as keyboard contraction - #3105
Draft
Chris0Jeky wants to merge 2 commits into
Draft
Chris0Jeky wants to merge 2 commits into
Chris0Jeky wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Take #1867 item 1 as a bounded, stacked policy decision.
useVisualViewporttreated everyVisualViewportresize identically, so browser pinch zoom (scale > 1) shrank and offset CardModal/TdDialog exactly like a software keyboard.The rule is now explicit:
visualViewport.heightandoffsetTopas before;layoutcallers exposewindow.innerHeight/0px;unsetcallers remove the custom properties so their CSSdvh/vhladder remains authoritative;Red → green evidence
RED — exact test-only head. Commit
b5affc810ec4f660f8d12103113fe0b94db4782aadded onlyuseVisualViewportPinchZoom.spec.ts. CI run34916243641, Ubuntu frontend job104214661061, passed lint, typecheck, production build, and PWA validation, then failed the frontend test phase. Its archived JUnit receipt contains exactly two failures, both in the new spec:260px, expected900px;260px, expected an absent custom property.No unrelated frontend test failed.
GREEN candidate. Commit
5f13a9f94d5db7dc8ee0b3c280aa62b4eae40d67adds the scale-aware classification and documents the policy. Its exact-head hosted matrix is the evidence gate; this PR remains draft until that matrix completes and because it is stacked on #3104.Scope
Refs #1867