Avoid re-announcing stale transcript failures on locale switch - #3106
Draft
Chris0Jeky wants to merge 2 commits into
Draft
Chris0Jeky wants to merge 2 commits into
Chris0Jeky wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Take #1871 review-i18n item 4 as a bounded accessibility slice. Transcript errors intentionally store a catalog key so visible copy can follow a locale change, but the visible paragraph was also
role="alert". Changing locale therefore announced the same already-known failure again as though a new failure occurred.The implementation separates the two responsibilities:
Red → green evidence
RED — exact test-only head. Commit
34430f9768b9b2515ae8da8702a48e90e379c9beadded onlyTranscriptEvidenceAnnouncement.spec.ts. CI run34916715674, Ubuntu frontend job104215866818, passed lint, typecheck, production build, and PWA validation before the frontend test phase failed. Its archived JUnit receipt reports 6,913 tests and exactly one failure, the new case:[data-testid="transcript-evidence-error-announcement"]node;role="alert".GREEN candidate. Commit
1f975bd64c6f24e6ea10bd249853b59d806d8754snapshots the failure-time translation for the one-time live region while retaining catalog-key-driven visible copy. Its exact-head hosted matrix is the evidence gate; this PR remains draft until that matrix settles.Scope
Refs #1871