Make Paper eyebrow absence explicit in root inventory - #3107
Draft
Chris0Jeky wants to merge 2 commits into
Draft
Chris0Jeky wants to merge 2 commits into
Chris0Jeky wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Address the concrete type-safety residual recorded after #2644 under #1868.
PAPER_VIEW_ROOTSis declared with an optionaleyebrow, but the two roots without one omitted the property entirely. Because the frontend-roottests/lane is not type-checked,flatMap(({ view, eyebrow }) => ...)could destructure a property the inferred union did not guarantee without any compiler receipt.The inventory now gives every entry the same structural keys. A root with no page eyebrow records
eyebrow: undefinedexplicitly, preserving the literal view-name union and existing filtering behavior.Red → green evidence
RED — exact test-only head. Commit
ec7667c13c37e829c7a0fe8470a82dd09e29f626added onlypaperRootInventory.spec.ts. CI run34916869708, Ubuntu frontend job104216664619, passed lint, typecheck, production build, and PWA validation, then failed the frontend test phase. Its archived JUnit receipt reports 6,913 tests and exactly one failure. The received missing-property list is precisely:AutomationChatView.vueDevToolsView.vueGREEN candidate. Commit
fb762d36366a190c92bea2ba5c9546f11b6ed822addseyebrow: undefinedto those two objects and changes no other inventory value. Its exact-head hosted matrix is the evidence gate; this PR remains draft until that matrix settles.Scope
Refs #1868