Close workspace preference interleaving gaps - #3110
Draft
Chris0Jeky wants to merge 2 commits into
Draft
Chris0Jeky wants to merge 2 commits into
Chris0Jeky wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Resolve the three client-state residuals recorded in #1410 without changing the server contract:
Red → green evidence
RED — exact test-only head. Commit
60e75e05d21eb97efe343167cd40d8150ee63610added five focused store regressions and no production changes. Main CI run34920286988, Ubuntu frontend job104226729173, passed lint, typecheck, build, and PWA validation before failing only in the frontend test phase. Its archived JUnit receipt contains exactly five failures, all inworkspaceStore.residualInterleavings.spec.ts:steps: [], null current step, and old dismissal timestamp;preferenceErrorafter logout;preferenceErrorafter logout;preferencesHydratedfalse;preferencesHydratedfalse.GREEN candidate. Commit
91936bc2a2abaa24d708ff2e0ad6b709a34ec545extends the existing per-field version/read-snapshot architecture. Smart CI run34920797590and CI Extended run34920797882are successful. Main CI run34920797772is still executing its exact-head matrix; this PR remains draft until that evidence settles.Design
finallyblocks still balance loading state without being able to mutate preference state.Scope
workspaceStoreordering/reconciliation semantics and focused tests only.main.Closes #1410